Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor intrinics implementation into separate sub-modules #20682

Merged
merged 9 commits into from
Mar 17, 2024

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Mar 17, 2024

All of the engine intrinsics are currently implemented in a single, very large file which is difficult to read and maintain.

This PR splits the intrinsics by function into separate sub-modules to make it easier to understand and maintain.

Note: The commits can be reviewed separately since they each focus on only refactoring one piece of functionality.

@tdyas tdyas added the category:internal CI, fixes for not-yet-released features, etc. label Mar 17, 2024
Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! :)

@tdyas tdyas merged commit cb8c323 into pantsbuild:main Mar 17, 2024
24 checks passed
@tdyas tdyas deleted the split_intrinsics_setup branch March 17, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants